inspector - Use script name for target title #8243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
| std::string AbsolutePath(const char* path) { | ||
| bool is_relative; | ||
| if (path && path[0]) { | ||
| char *file_name; |
|
LGTM, ping @bnoordhuis |
| @@ -220,8 +221,8 @@ static struct { | |||
| void Initialize(int thread_pool_size) {} | |||
| void PumpMessageLoop(Isolate* isolate) {} | |||
| void Dispose() {} | |||
| bool StartInspector(Environment *env, int port, bool wait) { | |||
| env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0"); | |||
| void StartInspector(Environment *env, const char* script_path, | |||
There was a problem hiding this comment.
Accidental change from bool to void?
There was a problem hiding this comment.
Merge artifact. Thank you for pointing it out.
|
Thank you for the review. I uploaded a revised CL, please take a look. |
|
|
||
| void Escape(std::string* string) { | ||
| int i = 0; | ||
| for (char c : *string) { |
There was a problem hiding this comment.
char& c? Then you don't need i.
|
LGTM with some comments. The missing |
|
Thank you for the review. CL was updated. Please take another look. |
|
LGTM EDIT: If you s/inspector - Use/inspector: use/ the commit log. |
|
I can fix the commit abstract at landing time. New CI: https://ci.nodejs.org/job/node-test-pull-request/3887/ |
|
@eugeneo: can you fix the linter errors from the CI? |
Changes inspector integration to use Node.js script file name as target title (reported in JSON and shown in developer tools UIs). It will also report file:// URL for the script as some tools seem to use that field to open the script in the editor.
|
Done. I'm sorry - forgot to run make cpplint... |
|
CI is green (enough). Failures are unrelated / buildbot issues. |
|
Landed as 609a265. |
ofrobots
pushed a commit
that referenced
this pull request
Sep 2, 2016
Changes inspector integration to use Node.js script file name as target title (reported in JSON and shown in developer tools UIs). It will also report file:// URL for the script as some tools seem to use that field to open the script in the editor. PR-URL: #8243 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Changes inspector integration to use Node.js script file name as target title (reported in JSON and shown in developer tools UIs). It will also report file:// URL for the script as some tools seem to use that field to open the script in the editor. PR-URL: nodejs#8243 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Conflicts: src/node.cc
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Changes inspector integration to use Node.js script file name as target title (reported in JSON and shown in developer tools UIs). It will also report file:// URL for the script as some tools seem to use that field to open the script in the editor. PR-URL: #8243 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Conflicts: src/node.cc
This was referenced Sep 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
This only touches JSON API of the V8 Inspector integration.
Description of change
Changes inspector integration to use Node.js script file name as target
title (reported in JSON and shown in developer tools UIs). It will also
report file:// URL for the script as some tools seem to use that field
to open the script in the editor.
CC: @ofrobots